Add scalacOptions for sourcemapping github paths #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI errors out during the JS tests: [info] [coreJS] compiling 203 Scala sources to /home/runner/work/smithy4s/smithy4s/modules/core/target/js-2.13/classes ...
[error] [coreJS] :file:/home/runner/work/smithy4s/smithy4s/.sbt/matrix/coreJS/ is not a valid URI
[error] [coreJS] one error found
[error] [coreJS] (coreJS / Compile / compileIncremental) Compilation failed
[error] Total time: 35 s, completed Jan 5, 2023, 11:58:46 PMI feel like I'm missing something here with my changes, but I can' quite figure out yet why the test fail. |
keynmol
reviewed
Jan 6, 2023
@zetashift Seconded :-)! |
armanbilge
reviewed
Jan 17, 2023
| val flag = | ||
| if (scalaVersion.value.startsWith("3")) "-scalajs-mapSourceURI" | ||
| else "-P:scalajs:mapSourceURI" | ||
| val localSourcesPath = baseDirectory.value.toURI |
There was a problem hiding this comment.
This should be (LocalRootProject / baseDirectory).value.toURI.toString, exactly like it is in sbt-typelevel.
There was a problem hiding this comment.
You're my hero.
I'll try to get a PR that fixes it today!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully fixes #705
Code is an amalgamation of https://github.com/typelevel/sbt-typelevel/blob/4da726ca021ea2c6459e8286d9ec49ab7c79a883/github/src/main/scala/org/typelevel/sbt/TypelevelScalaJSGitHubPlugin.scala#L34 and https://github.com/raquo/Laminar/blob/739cc0dbab319c685f28be30a1592b7d04347842/build.sbt#L76
Feedback is very much welcome, the code could be a lot simpler like the code from Laminar.